linux-kernel - Re: [PATCH] auxdisplay: charlcd: delete mdelay in long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180129065053.GC20230@1wt.eu>
Date:   Mon, 29 Jan 2018 07:50:53 +0100
From:   Willy Tarreau <w@....eu>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     miguel.ojeda.sandonis@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] auxdisplay: charlcd: delete mdelay in long_sleep

Hi,

On Fri, Jan 26, 2018 at 11:19:15PM +0800, Jia-Ju Bai wrote:
> The function long_sleep() calls mdelay() when in an interrupt handler.
> But only charlcd_clear_display() and charlcd_init_display calls 
> long_sleep(), and my tool finds that the two functions 
> are never called in an interrupt handler.
> Thus mdelay() and in_interrupt() are not necessary.
> 
> This is found by a static analysis tool named DCNS written by myself.

Looks good. This code is extremely old (started in 2.2) so I'm not
surprised at all that after many changes such parts are not used
anymore.

Acked-by: Willy Tarreau <w@....eu>

Willy