linux-kernel - Re: [PATCH v19 03/10] video: backlight: Add of_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180129091120.xs74nu75fype2amq@dell>
Date:   Mon, 29 Jan 2018 09:11:20 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Meghana Madhyastha <meghana.madhyastha@...il.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Noralf Trønnes <noralf@...nnes.org>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Sean Paul <seanpaul@...omium.org>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper
 in backlight.c

On Fri, 26 Jan 2018, Randy Dunlap wrote:

> On 01/26/2018 01:48 AM, Lee Jones wrote:
> > On Wed, 24 Jan 2018, Meghana Madhyastha wrote:
> > 
> >> Add of_find_backlight, a helper function which is a generic version
> >> of tinydrm_of_find_backlight that can be used by other drivers to avoid
> >> repetition of code and simplify things.
> >>
> >> Acked-by: Daniel Thompson <daniel.thompson@...aro.org>
> >> Reviewed-by: Noralf Trønnes <noralf@...nnes.org>
> >> Reviewed-by: Sean Paul<seanpaul@...omium.org>
> >> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@...il.com>
> > 
> > Nit: These should be in chronological order.
> 
> Where does that tidbit of information come from?
> I have never heard or read that.

Not sure it is documented anywhere.  It appeared to be the widely
used, most sensible approach, so I adopted it a few years ago.

This method provides us with information which would otherwise be
absent; including description of the patch submission/acceptance path
and an idea of who did what, when.

For example:

Original Author sign-off
Original Co-author sign-off
[Additional contributions: rebase, API changes, fix-ups]
Re-worker's sign-off
Tester's tested-by
Reviewer's acked-by/reviewed-by
Level-2 Maintainer sign-off
Level-1 Maintainer sign-off

Are you aware of a more functional/practical/useful method?

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog