linux-kernel - Re: [PATCH 18/35] objtool: Another static block fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180129182402.GY2269@hirez.programming.kicks-ass.net>
Date:   Mon, 29 Jan 2018 19:24:02 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, Dave Hansen <dave.hansen@...el.com>,
        Ashok Raj <ashok.raj@...el.com>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Jun Nakajima <jun.nakajima@...el.com>,
        Asit Mallick <asit.k.mallick@...el.com>,
        Jason Baron <jbaron@...mai.com>
Subject: Re: [PATCH 18/35] objtool: Another static block fail

On Mon, Jan 29, 2018 at 12:01:05PM -0600, Josh Poimboeuf wrote:
> On Fri, Jan 19, 2018 at 05:42:29PM +0100, Peter Zijlstra wrote:
> > Josh, how would you feel about adding the bits required to make objtool
> > a full disassembler? That would make it far easier to visualse the state
> > and I don't think its _that_ much more, all the difficult bits are
> > already done afaict, all we need is infrastructure to print the already
> > fully decoded instruction.
> 
> It sounds interesting, but I have no idea what you mean :-)  Can you
> elaborate?

Well, having had to debug the objtool state, I end up printing
sec+offset and then matching up with objdump output. It might be easier
to just print annotated assembly in one go.

Of course, to make that so, we have this small matter of actually
implementing the bits that print the instructions first ;-)