linux-kernel - Re: [PATCH v7] Support intel-vbtn based tablet mode switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD6_BoviBRVRSG++fYRZ1Pg7spMD=jS2j5zeVHTK7eTWVY3sgg@mail.gmail.com>
Date:   Mon, 29 Jan 2018 21:33:20 +0100
From:   Marco Martin <notmart@...il.com>
To:     Mario Limonciello <Mario.Limonciello@...l.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bhushan Shah <bhush94@...il.com>,
        Stefan Brüns <stefan.bruens@...h-aachen.de>
Subject: Re: [PATCH v7] Support intel-vbtn based tablet mode switch

On Mon, Jan 29, 2018 at 8:35 PM,  <Mario.Limonciello@...l.com> wrote:
>> -----Original Message-----
>> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
>> Sent: Monday, January 29, 2018 12:57 PM
>> To: Marco Martin <notmart@...il.com>
>> Cc: Platform Driver <platform-driver-x86@...r.kernel.org>; Limonciello, Mario
>> <Mario_Limonciello@...l.com>; Andy Shevchenko <andy@...radead.org>; Pali
>> Rohár <pali.rohar@...il.com>; Darren Hart <dvhart@...radead.org>; Matthew
>> Garrett <mjg59@...f.ucam.org>; Linux Kernel Mailing List <linux-
>> kernel@...r.kernel.org>; Bhushan Shah <bhush94@...il.com>
>> Subject: Re: [PATCH v7] Support intel-vbtn based tablet mode switch
>>
>> On Sat, Jan 27, 2018 at 6:35 PM, Marco Martin <notmart@...il.com> wrote:
>> > Some laptops such as Dell Inspiron 7000 series have the
>> > tablet mode switch implemented in Intel ACPI,
>> > the events to enter and exit the tablet mode are 0xCC and 0xCD
>> >
>>
>> It doesn't apply :-(
>
> Marco, I can see it applies on 4.15 but it's not applying on platform-drivers-x86/testing.
> It's most likely this commit you need to rebase on top of:

Ah, i see (i was trying on platform-drivers-x86 but master branch, sorry)
latest version is rebased on top of it, i seen the reason it didn't
apply was that the addition
 to sparse_keymap was already done in 1c8284 by Stefan Brüns (whoops :)
However still needs the initialization part, so booting or
modprobe with the device already in tablet mode would initialize the
correct state

--
Marco Martin