linux-kernel - Re: [PATCH 1/1] scsi: ufs-qcom: remove broken hci version quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <525ba25a-b699-3bb3-df06-4b3ff165d42a@codeaurora.org>
Date:   Tue, 30 Jan 2018 12:24:50 +0530
From:   "Asutosh Das (asd)" <asutoshd@...eaurora.org>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>,
        subhashj@...eaurora.org, cang@...eaurora.org,
        rnayak@...eaurora.org, vinholikatti@...il.com,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] scsi: ufs-qcom: remove broken hci version quirk

On 1/30/2018 11:33 AM, Vivek Gautam wrote:
> Hi Asutosh,
> 
> 
> On 1/30/2018 10:11 AM, Asutosh Das wrote:
>> From: Subhash Jadavani <subhashj@...eaurora.org>
>>
>> UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host
>> controller version 2.x.y and this has been fixed from version 3.x.y
>> onwards, hence this change removes this quirk for version 3.x.y onwards.
>>
>> Signed-off-by: Subhash Jadavani <subhashj@...eaurora.org>
>> Signed-off-by: Asutosh Das <asutoshd@...eaurora.org>
>> ---
> 
> This patch and all other ufs patches that you have posted recently,
> do they all fall under one 'ufs-qcom fixes' patch series for fixes that
> we would want to do?
> If it is so, then please club them together in a series, so that
> it's easy for reviewers and maintainers to review, and keep track
> of all the patches that can get-in after the reviews.
> If they belong to two or more separate patch-series then please
> create such patch series.
> It's difficult to read through a lot of [PATCH 1/1] ... patch.
Sure Vivek - Makes sense. Will resend it.

> 
> Regards
> Vivek
> 
>>   drivers/scsi/ufs/ufs-qcom.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
>> index 2b38db2..221820a 100644
>> --- a/drivers/scsi/ufs/ufs-qcom.c
>> +++ b/drivers/scsi/ufs/ufs-qcom.c
>> @@ -1098,7 +1098,7 @@ static void ufs_qcom_advertise_quirks(struct 
>> ufs_hba *hba)
>>           hba->quirks |= UFSHCD_QUIRK_BROKEN_LCC;
>>       }
>> -    if (host->hw_ver.major >= 0x2) {
>> +    if (host->hw_ver.major == 0x2) {
>>           hba->quirks |= UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION;
>>           if (!ufs_qcom_cap_qunipro(host))
> 


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project