[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20180130053708.GA3741@linux.vnet.ibm.com>
Date: Mon, 29 Jan 2018 21:37:08 -0800
From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To: Ildar Ismagilov <devix84@...il.com>
Cc: Josh Triplett <josh@...htriplett.org>,
Steven Rostedt <rostedt@...dmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Lai Jiangshan <jiangshanlai@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] srcu: fix misprint in srcu_funnel_exp_start
On Mon, Jan 29, 2018 at 09:23:09PM +0300, Ildar Ismagilov wrote:
> Signed-off-by: Ildar Ismagilov <devix84@...il.com>
The original does look backwards, now that you mention it, thank you
for sending it.
Did you see any performance differences from this patch?
Thanx, Paul
> ---
> kernel/rcu/srcutree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index 6d5880089ff6..1798d1aa60fa 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -599,7 +599,7 @@ static void srcu_funnel_exp_start(struct srcu_struct *sp, struct srcu_node *snp,
> raw_spin_unlock_irqrestore_rcu_node(snp, flags);
> }
> raw_spin_lock_irqsave_rcu_node(sp, flags);
> - if (!ULONG_CMP_LT(sp->srcu_gp_seq_needed_exp, s))
> + if (ULONG_CMP_LT(sp->srcu_gp_seq_needed_exp, s))
> sp->srcu_gp_seq_needed_exp = s;
> raw_spin_unlock_irqrestore_rcu_node(sp, flags);
> }
> --
> 2.11.0
>
Powered by blists - more mailing lists