linux-kernel - Re: [PATCH] drm/edid: use false for boolean value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180130040222.Horde.f-T_LoXaosAs8kCmN9RdOXK@gator4166.hostgator.com>
Date:   Tue, 30 Jan 2018 04:02:22 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Daniel Vetter <daniel@...ll.ch>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Gustavo Padovan <gustavo@...ovan.org>,
        Sean Paul <seanpaul@...omium.org>,
        David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/edid: use false for boolean value

Hi Daniel,

Quoting Daniel Vetter <daniel@...ll.ch>:

> On Tue, Jan 23, 2018 at 10:46:07AM -0600, Gustavo A. R. Silva wrote:
>> Assign true or false to boolean variables instead of an integer value.
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>
> Thanks for your patch.
>
>> ---
>>  drivers/gpu/drm/drm_edid.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index ddd5379..45a80d7 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing  
>> *timing, void *c)
>>
>>  		drm_mode_probed_add(closure->connector, newmode);
>>  		closure->modes++;
>> -		closure->preferred = 0;
>> +		closure->preferred = false;
>
> There's also
>
> 		.preferred = 1,
>
> in add_detailed_modes. Please fix that one up too for consistency, then
> I'll merge your patch.
>

Sure. I'll send a new patch shortly.

I also need to update the Coccinelle script to catch those cases.

Thanks for the feedback.
--
Gustavo