[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <75fe97b4-ff59-e7cf-3f0c-085b281ead80@st.com>
Date: Tue, 30 Jan 2018 14:29:13 +0000
From: Philippe CORNU <philippe.cornu@...com>
To: Archit Taneja <architt@...eaurora.org>,
Brian Norris <briannorris@...omium.org>
CC: "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
"linux-rockchip@...ts.infradead.org"
<linux-rockchip@...ts.infradead.org>,
David Airlie <airlied@...ux.ie>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"Yannick FERTRE" <yannick.fertre@...com>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Ludovic BARRE <ludovic.barre@...com>,
Mickael REULIER <mickael.reulier@...com>,
Vincent ABRIOU <vincent.abriou@...com>,
Bhumika Goyal <bhumirks@...il.com>,
Alexandre TORGUE <alexandre.torgue@...com>
Subject: Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi
read requests
Hi Archit,
And many thanks,
Philippe :-)
On 01/30/2018 03:09 PM, Archit Taneja wrote:
>
>
> On 01/26/2018 06:14 AM, Brian Norris wrote:
>> On Thu, Jan 25, 2018 at 11:37:59AM +0100, Philippe Cornu wrote:
>>> The dcs/generic dsi read feature is not yet implemented so it
>>> is important to warn the host_transfer() caller in case of
>>> read operation requests.
>>>
>>> Signed-off-by: Philippe Cornu <philippe.cornu@...com>
>>
>> Awesome, thanks.
>>
>> Reviewed-by: Brian Norris <briannorris@...omium.org>
>>
>
> Queued to drm-misc-next.
>
> Thanks,
> Archit
>
>>> ---
>>> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> index daec7881be6d..72ecaeb40822 100644
>>> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> @@ -405,6 +405,12 @@ static ssize_t dw_mipi_dsi_host_transfer(struct
>>> mipi_dsi_host *host,
>>> struct mipi_dsi_packet packet;
>>> int ret;
>>> + if (msg->rx_buf || msg->rx_len) {
>>> + /* TODO dw drv improvements: implement read feature */
>>> + dev_warn(dsi->dev, "read operations not yet implemented\n");
>>> + return -EINVAL;
>>> + }
>>> +
>>> ret = mipi_dsi_create_packet(&packet, msg);
>>> if (ret) {
>>> dev_err(dsi->dev, "failed to create packet: %d\n", ret);
>>> --
>>> 2.15.1
>>>
>
Powered by blists - more mailing lists