linux-kernel - Re: [PATCH] staging: lustre: lnet: return of an error code should be negative

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Jan 2018 01:49:17 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     Sumit Pundir <pundirsumit11@...il.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        "jsimmons@...radead.org" <jsimmons@...radead.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: lustre: lnet: return of an error code should
 be negative

On Jan 27, 2018, at 22:24, Sumit Pundir <pundirsumit11@...il.com> wrote:
> 
> Return value of error codes should typically be negative.
> Issue reported by checkpatch.pl
> 
> Signed-off-by: Sumit Pundir <pundirsumit11@...il.com>

Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>

> ---
> drivers/staging/lustre/lnet/selftest/framework.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c
> index c7697f6..0ca1e3a 100644
> --- a/drivers/staging/lustre/lnet/selftest/framework.c
> +++ b/drivers/staging/lustre/lnet/selftest/framework.c
> @@ -187,7 +187,7 @@ sfw_del_session_timer(void)
> 		return 0;
> 	}
> 
> -	return EBUSY; /* racing with sfw_session_expired() */
> +	return -EBUSY; /* racing with sfw_session_expired() */
> }
> 
> static void
> -- 
> 2.7.4
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation