linux-kernel - Re: [PATCH] drm: amd: Fix trailing semicolons

Open Source and information security mailing list archives

Message-ID: <CADnq5_Ny_0HZAt9b-D+k7zryowW0hkBtHp2i+k=KN7bfvBMhAg@mail.gmail.com>
Date:   Tue, 30 Jan 2018 14:23:48 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Luis de Bethencourt <luisbg@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, Huang Rui <ray.huang@....com>,
        David Airlie <airlied@...ux.ie>,
        Harry Wentland <harry.wentland@....com>,
        Wenjing Liu <Wenjing.Liu@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Ding Wang <Ding.Wang@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Eric Huang <JinHuiEric.Huang@....com>,
        Sylvia Tsai <sylvia.tsai@....com>,
        Hersen Wu <hersenxs.wu@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, Joe Perches <joe@...ches.com>,
        Rex Zhu <Rex.Zhu@....com>, Tony Cheng <tony.cheng@....com>,
        Christian Konig <christian.koenig@....com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] drm: amd: Fix trailing semicolons

On Wed, Jan 17, 2018 at 1:50 PM, Luis de Bethencourt <luisbg@...nel.org> wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing the two instances of them since they don't do anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@...nel.org>

Applied.  thanks!

Alex

> ---
>
> Hi,
>
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
>  drivers/gpu/drm/amd/powerplay/amd_powerplay.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 61e8c3e02d16..33d91e4474ea 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(
>         uint32_t retries_ch_eq;
>         enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;
>         union lane_align_status_updated dpcd_lane_status_updated = {{0}};
> -       union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX] = {{{0}}};;
> +       union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX] = {{{0}}};
>
>         hw_tr_pattern = get_supported_tp(link);
>
> diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> index fa9d1615a2cc..b98a7a8a22b5 100644
> --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> @@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)
>                 if(hwmgr->smumgr_funcs->start_smu(pp_handle->hwmgr)) {
>                         pr_err("smc start failed\n");
>                         hwmgr->smumgr_funcs->smu_fini(pp_handle->hwmgr);
> -                       return -EINVAL;;
> +                       return -EINVAL;
>                 }
>                 if (ret == PP_DPM_DISABLED)
>                         goto exit;
> --
> 2.15.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives