linux-kernel - Re: [PATCH v2 01/43] drm/rockchip: Get rid of unnecessary struct fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0450cb94-962e-7b17-3d3a-2cf3c8f504c4@rock-chips.com>
Date:   Tue, 30 Jan 2018 10:21:21 +0800
From:   Sandy Huang <hjc@...k-chips.com>
To:     Thierry Escande <thierry.escande@...labora.com>,
        Archit Taneja <architt@...eaurora.org>,
        Inki Dae <inki.dae@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Sean Paul <seanpaul@...omium.org>,
        David Airlie <airlied@...ux.ie>,
        Tomasz Figa <tfiga@...omium.org>
Cc:     Zain Wang <wzz@...k-chips.com>, Lin Huang <hl@...k-chips.com>,
        Douglas Anderson <dianders@...omium.org>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        Ørjan Eide <orjan.eide@....com>,
        Haixia Shi <hshi@...omium.org>
Subject: Re: [PATCH v2 01/43] drm/rockchip: Get rid of unnecessary struct
 fields



在 2018/1/26 21:16, Thierry Escande 写道:
> From: Tomasz Figa <tfiga@...omium.org>
> 
> This patch removes unused fields from vop structure.
> 
> Signed-off-by: Tomasz Figa <tfiga@...omium.org>
> Signed-off-by: Sean Paul <seanpaul@...omium.org>
> Signed-off-by: Thierry Escande <thierry.escande@...labora.com>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index ba7505292b78..7a137bc5708c 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -95,9 +95,6 @@ struct vop {
>   	struct drm_device *drm_dev;
>   	bool is_enabled;
>   
> -	/* mutex vsync_ work */
> -	struct mutex vsync_mutex;
> -	bool vsync_work_pending;
>   	struct completion dsp_hold_completion;
>   
>   	/* protected by dev->event_lock */
> @@ -1567,8 +1564,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
>   	spin_lock_init(&vop->reg_lock);
>   	spin_lock_init(&vop->irq_lock);
>   
> -	mutex_init(&vop->vsync_mutex);
> -
>   	ret = devm_request_irq(dev, vop->irq, vop_isr,
>   			       IRQF_SHARED, dev_name(dev), vop);
>   	if (ret)
> 
Reviewed-by: Sandy huang <hjc@...k-chips.com>