linux-kernel - Re: [PATCHv3 0/3] x86/mm/encrypt: Cleanup and switching between paging modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <830ed299-53a7-f357-9301-5b6577d55f30@amd.com>
Date:   Tue, 30 Jan 2018 16:52:13 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Borislav Petkov <bp@...e.de>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 0/3] x86/mm/encrypt: Cleanup and switching between
 paging modes

On 1/24/2018 10:36 AM, Kirill A. Shutemov wrote:
> This patcheset is a preparation set for boot-time switching between
> paging modes. Please review and consider applying.
> 
> Code around sme_populate_pgd() is unnecessary complex and hard to modify.
> 
> This patchset rewrites it in more stream-lined way to add support of
> boot-time switching between paging modes.
> 
> I haven't tested the patchset on hardware capable of memory encryption.

Tested-by: Tom Lendacky <thomas.lendacky@....com>

> 
> v3:
>  - Move all page table related functions into mem_encrypt_identity.c
> v2:
>  - Rebased to up-to-date tip
> 
> Kirill A. Shutemov (3):
>   x86/mm/encrypt: Move page table helpers into separate translation unit
>   x86/mm/encrypt: Rewrite sme_populate_pgd() and
>     sme_populate_pgd_large()
>   x86/mm/encrypt: Rewrite sme_pgtable_calc()
> 
>  arch/x86/mm/Makefile               |  14 +-
>  arch/x86/mm/mem_encrypt.c          | 578 +------------------------------------
>  arch/x86/mm/mem_encrypt_identity.c | 563 ++++++++++++++++++++++++++++++++++++
>  arch/x86/mm/mm_internal.h          |   1 +
>  4 files changed, 574 insertions(+), 582 deletions(-)
>  create mode 100644 arch/x86/mm/mem_encrypt_identity.c
>