linux-kernel - Re: [git pull] vfs.git: poll annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180131031300.GE29051@ZenIV.linux.org.uk>
Date:   Wed, 31 Jan 2018 03:13:00 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>
Subject: Re: [git pull] vfs.git: poll annotations

On Tue, Jan 30, 2018 at 06:21:37PM -0800, Linus Torvalds wrote:
> On Tue, Jan 30, 2018 at 10:39 AM, Al Viro <viro@...iv.linux.org.uk> wrote:
> >         Introduces a __bitwise type for POLL... bitmap, propagates
> > the annotations through the tree.
> 
> Ok, I'm not entirely happy with this.
> 
> I don't think the mangle/demangle_poll() stuff should be in the uapi
> headers, and it really worries me that we use the same names - with
> different values - for the kernel and user versions of the POLLxyz
> macros.

I'm not happy with that either, but the alternative would be to
rename almost every instance of POLL... in the tree.  All of them
except for poll.h, actually.  And then keep playing whack-a-mole
for resurfacing POLL... in drivers.

Sure, we can do that, but at least let's do that as a single
search-and-replace job in -rc1.  Too many conflicts otherwise.
No need to invent KPOLLIN et.al. - we have perfectly usable
EPOLLIN and friends.

A bit of a problem in places like
                        mask & POLLOUT ? "POLLOUT" : "",
but it's not too terrible.  I'll experiment a bit - should be able to
post a script to run.

As for the place for mangle/demangle... where would you prefer them?