linux-kernel - Re: 4.15: WARNING: CPU: 3 PID: 258 at kernel/irq/chip.c:244 __irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1801310856390.2293@nanos>
Date:   Wed, 31 Jan 2018 08:58:32 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Meelis Roos <mroos@...ux.ee>
cc:     Linux Kernel list <linux-kernel@...r.kernel.org>, x86@...nel.org
Subject: Re: 4.15: WARNING: CPU: 3 PID: 258 at kernel/irq/chip.c:244
 __irq_startup+0x80/0x100

On Wed, 31 Jan 2018, Meelis Roos wrote:
> > > Your supply of vintage hardware is amazing.
> 
> :-)
> 
> > Does the patch below fix the issue for you?
> 
>   CC      kernel/irq/autoprobe.o
> kernel/irq/autoprobe.c: In function ‘probe_irq_on’:
> kernel/irq/autoprobe.c:74:8: error: void value not ignored as it ought to be
>     if (irq_activate_and_startup(desc, IRQ_NORESEND))
>         ^~~~~~~~~~~~~~~~~~~~~~~~

Duh.

> Just 
> irq_activate_and_startup(desc, IRQ_NORESEND);

Indeed. 

> cures the warning and at least the first bootup was working otherwise 
> too.

I'll do a proper fix and queue it so your museum is kept alive.

Thanks,

	tglx