[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <567f779c-591c-4798-a8d0-504d25c439de@cogentembedded.com>
Date: Wed, 31 Jan 2018 11:07:44 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Jacopo Mondi <jacopo+renesas@...ndi.org>,
laurent.pinchart@...asonboard.com, magnus.damm@...il.com,
geert@...der.be, hverkuil@...all.nl, mchehab@...nel.org,
festevam@...il.com, sakari.ailus@....fi, robh+dt@...nel.org,
mark.rutland@....com, pombredanne@...b.com
Cc: linux-renesas-soc@...r.kernel.org, linux-media@...r.kernel.org,
linux-sh@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 04/11] ARM: dts: r7s72100: Add Capture Engine Unit
(CEU)
Hello!
On 1/30/2018 12:58 PM, Jacopo Mondi wrote:
> Add Capture Engine Unit (CEU) node to device tree.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Acked-by: Hans Verkuil <hans.verkuil@...co.com>
> ---
> arch/arm/boot/dts/r7s72100.dtsi | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
> index ab9645a..5fe62f9 100644
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
[...]
> @@ -667,4 +667,13 @@
> power-domains = <&cpg_clocks>;
> status = "disabled";
> };
> +
> + ceu: ceu@...10000 {
The DT spec dictates the generic node names should be used. For the R-Car
VIN we use "video@...", hence I suggest that use the same here.
> + reg = <0xe8210000 0x3000>;
> + compatible = "renesas,r7s72100-ceu";
> + interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp6_clks R7S72100_CLK_CEU>;
> + power-domains = <&cpg_clocks>;
> + status = "disabled";
> + };
> };
MBR, Sergei
Powered by blists - more mailing lists