linux-kernel - Re: [PATCH] Staging: speakup: Fixed a multiple assignment issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Jan 2018 09:41:04 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Shannon Booth <shannon.ml.booth@...il.com>
Cc:     devel@...verdev.osuosl.org, speakup@...ux-speakup.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: speakup: Fixed a multiple assignment issue

On Wed, Jan 31, 2018 at 07:19:05PM +1300, Shannon Booth wrote:
> Fixed a coding style issue.
> 
> Signed-off-by: Shannon Booth <shannon.ml.booth@...il.com>
> ---
>  drivers/staging/speakup/main.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index cf12590..b721f41 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -261,9 +261,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
>  
>  static void speakup_date(struct vc_data *vc)
>  {
> -	spk_x = spk_cx = vc->vc_x;
> -	spk_y = spk_cy = vc->vc_y;
> -	spk_pos = spk_cp = vc->vc_pos;
> +	spk_x =  vc->vc_x;
> +	spk_cx = vc->vc_x;
> +	spk_y = vc->vc_y;
> +	spk_cy = vc->vc_y;
> +	spk_pos =  vc->vc_pos;
> +	spk_cp = vc->vc_pos;

The original code looks much better than this, don't you agree?

Coding style is just a guideline, no need to change things that don't
make sense.

thanks,

greg k-h