linux-kernel - Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180131084620.kkok5rpfbqakhyps@mwanda>
Date:   Wed, 31 Jan 2018 11:46:20 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ulf Magnusson <ulfalizer@...il.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        "Luis R . Rodriguez" <mcgrof@...nel.org>
Subject: Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
> >> In preparation for adding a warning ("kconfig: Warn if help text is
> >> blank"): https://lkml.org/lkml/2018/1/30/516
> >>
> >
> > Please don't start the boddy of the email in the middle of a sentence.
> >
> > It looks like this:
> >
> > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
> >
> > Notice how the subject is up above the From, Date, and Message-id email
> > headers?  It's totally disconnected from the body of the email.
> >
> > regards,
> > dan carpenter
> 
> The 'this is in...' was implied. I'll try to be less of a sloppy bastard.
> 

I do feel that patch descriptions should say what the patch does as well
as why.  Right now the subject says what but I normally read either the
body or the subject but not both.

regards,
dan carpenter