linux-kernel - Re: [PATCH 3.18 00/52] 3.18.93-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180131085213.GA3445@kroah.com>
Date:   Wed, 31 Jan 2018 09:52:13 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, shuahkh@....samsung.com,
        patches@...nelci.org, ben.hutchings@...ethink.co.uk,
        lkft-triage@...ts.linaro.org, stable@...r.kernel.org
Subject: Re: [PATCH 3.18 00/52] 3.18.93-stable review

On Tue, Jan 30, 2018 at 11:48:58AM -0800, Guenter Roeck wrote:
> On Tue, Jan 30, 2018 at 07:51:31PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Jan 30, 2018 at 03:51:56PM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 30, 2018 at 06:19:15AM -0800, Guenter Roeck wrote:
> > > > On 01/29/2018 04:56 AM, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 3.18.93 release.
> > > > > There are 52 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > > 
> > > > > Responses should be made by Wed Jan 31 12:36:07 UTC 2018.
> > > > > Anything received after that time might be too late.
> > > > > 
> > > > 
> > > > Build results:
> > > > 	total: 136 pass: 135 fail: 1
> > > > Failed builds:
> > > > 	um:defconfig
> > > > Qemu test results:
> > > > 	total: 112 pass: 112 fail: 0
> > > > 
> > > > The build failure is:
> > > > 
> > > > In file included from arch/um/kernel/config.c:8:0:
> > > > arch/um/include/shared/init.h:43:28: fatal error: linux/compiler.h: No such file or directory
> > > > 
> > > > [ several instances ]
> > > 
> > > Crap, I was trying to apply a number of the UM patches that Android
> > > relies on for their build systems that they patch their kernel for.
> > > I'll go look into those to try to figure out what I got wrong...
> > 
> > Ok, I can't even build a defconfig for ARCH=um at all, with no patches
> > applied to 3.18.  I had to go find a 4.9.4 kernel to even get close to
> > building, gcc7 did really odd things.
> > 
> > Do you have the .config file you use to build this arch with?  I looked
> > on the builder site and couldn't seem to find it anywhere, am I just
> > missing something obvious?
> > 
> 
> mkdir /tmp/build
> make O=/tmp/build ARCH=um SUBARCH=x86_64 defconfig
> make O=/tmp/build ARCH=um SUBARCH=x86_64 -j30
> 
> The O= is essential; in-tree builds are fine.

in-tree builds does not work for me either :(

> Also, turns out you are correct; 3.18.92 fails to build for me
> as well if I use a recent compiler. It does build with the compiler
> from Poky 1.3. Bisect points to commit a3a8321bf0f00 ("um: Remove
> copy&paste code from init.h)"; bisect log is attached.
> Not sure if it is worth fixing it, though. Maybe I should just
> stop building it for 3.18 instead. Thoughts ?

Let me pull the um patches out of this release, queue them up for the
next one after this, and try to figure out what is going on in a more
relaxed way.  I don't want the "real" bugfixes that are queued up right
now to be stopped from being released due to this odd arch.

I'll look into this later this week, no need for you to pull this out of
your build system just yet.

thanks,

greg k-h