linux-kernel - Re: [PATCH] kconfig: Warn if help text is blank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFkk2KTCcDH8c5BVzAZHykH3jRmPxt36wqr0PHSw1Hhr3DUoBw@mail.gmail.com>
Date:   Wed, 31 Jan 2018 10:53:15 +0100
From:   Ulf Magnusson <ulfalizer@...il.com>
To:     Paul Bolle <pebolle@...cali.nl>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH] kconfig: Warn if help text is blank

On Tue, Jan 30, 2018 at 9:31 PM, Paul Bolle <pebolle@...cali.nl> wrote:
> On Tue, 2018-01-30 at 20:33 +0100, Ulf Magnusson wrote:
>> I agree that this shouldn't go in until/unless a significant portion
>> of those empty help texts get removed first.
>
> Not a significant portion, but all, I'd say.
>
>> The patchset that removes the empty help texts is at
>> https://lkml.org/lkml/2018/1/30/574. I could make another one if you'd
>> prefer that.
>
> I'm fine with anything that doesn't add warnings just to appease pet peeves.
>
>> I haven't even checked how they are rendered to be honest. I was more
>> concerned with the Kconfig mess.
>
> Well, if you could make empty help texts disappear somehow (either during the
> Kconfig parse phase - which requires a jump into the yacc horror - or during
> the rendering phase) that would be much better than adding a warning for
> something that you yourself described as a pet peeve.
>
> And after that's done you're free to send cleanup patches for this whenever
> you feel like doing so.
>
> Thanks,
>
>
> Paul Bolle

I rolled a new patchset which adds the warning at the end and makes
the commits that remove the blank help texts more freestanding:
https://lkml.org/lkml/2018/1/31/137

Cheers,
Ulf