linux-kernel - Re: [PATCH] staging: android: ion: minor cleanup for ion_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Jan 2018 12:32:29 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yisheng Xie <xieyisheng1@...wei.com>
Cc:     devel@...verdev.osuosl.org, sumit.semwal@...aro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool

On Wed, Jan 31, 2018 at 05:50:52PM +0800, Yisheng Xie wrote:
> ion_page_pool.c now is used to apply pool APIs for system heap, which do
> not need do any initial at device_initcall.
> 
> Meanwhile, this patch also remove some useless include files.

Please only do one thing per patch, otherwise if one of the different
things you do has a problem, all of the changes have been reverted.

Yeah, it's a pain at times, but that's the way kernel development is,
sorry.

Please break this up into two patches and resend.  I will be glad to
queue them up after the merge window ends when 4.16-rc1 is released.

thanks,

greg k-h