linux-kernel - Re: [PATCH v2 1/2] Add notrace to lib/ucmpdi2.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aeb636ad-571e-104d-e180-8f60877de571@mips.com>
Date:   Wed, 31 Jan 2018 11:54:48 +0000
From:   Matt Redfearn <matt.redfearn@...s.com>
To:     Antony Pavlov <antonynpavlov@...il.com>,
        <linux-mips@...ux-mips.org>
CC:     James Hogan <jhogan@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        <linux-kernel@...r.kernel.org>, Palmer Dabbelt <palmer@...ive.com>
Subject: Re: [PATCH v2 1/2] Add notrace to lib/ucmpdi2.c

Hi

On 30/01/18 22:42, Antony Pavlov wrote:
> From: Palmer Dabbelt <palmer@...ive.com>
> 
> As part of the MIPS conversion to use the generic GCC library routines,
> Matt Redfearn discovered that I'd missed a notrace on __ucmpdi2().  This
> patch rectifies the problem.
> 
> CC: Matt Redfearn <matt.redfearn@...s.com>
> CC: Antony Pavlov <antonynpavlov@...il.com>
> Signed-off-by: Palmer Dabbelt <palmer@...ive.com>


Looks good to me :-)
Reviewed-by: Matt Redfearn <amtt.redfearn@...s.com>

> ---
>   lib/ucmpdi2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/ucmpdi2.c b/lib/ucmpdi2.c
> index 25ca2d4c1e19..597998169a96 100644
> --- a/lib/ucmpdi2.c
> +++ b/lib/ucmpdi2.c
> @@ -17,7 +17,7 @@
>   #include <linux/module.h>
>   #include <linux/libgcc.h>
>   
> -word_type __ucmpdi2(unsigned long long a, unsigned long long b)
> +word_type notrace __ucmpdi2(unsigned long long a, unsigned long long b)
>   {
>   	const DWunion au = {.ll = a};
>   	const DWunion bu = {.ll = b};
>