linux-kernel - Re: Change in register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce6d8040-3a1e-4137-e7b1-2066b9e56f42@deltatee.com>
Date:   Tue, 30 Jan 2018 18:26:38 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     "Srivatsa S. Bhat" <srivatsa@...il.mit.edu>,
        gregkh@...uxfoundation.org
Cc:     axboe@...nel.dk, jlayton@...chiereds.net, bfields@...ldses.org,
        linux-kernel@...r.kernel.org
Subject: Re: Change in register_blkdev() behavior

On 30/01/18 05:56 PM, Srivatsa S. Bhat wrote:
> If the restriction on the major number was intentional, perhaps we
> should get the LTP testcase modified for kernel versions >= 4.14.
> Otherwise, we should fix register_blkdev to preserve the old behavior.
> (I guess the same thing applies to commit 8a932f73e5b "char_dev: order
> /proc/devices by major number" as well).

The restriction was put in place so the code that prints the devices 
doesn't have to run through every integer in order to print the devices 
in order.

Given the existing documented fixed numbers in [1] and that future new 
char devices should be using dynamic allocation, this seemed like a 
reasonable restriction.

It would be pretty trivial to increase the limit but, IMO, setting it to 
UINT_MAX seems a bit much. Especially given that a lot of the 
documentation and code still very much has remnants of the 256 limit. 
(The series that included this patch only just expanded the char dynamic 
range to  above 256). So, I'd suggest the LTP test should change.

Logan

[1] Documentation/admin-guide/devices.txt