[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75Vc_8v3qxWjtT4B3Kvz4dNZ8=-+uRPs-iTK3o8Taa4Swgw@mail.gmail.com>
Date: Wed, 31 Jan 2018 14:58:57 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Colin King <colin.king@...onical.com>
Cc: Daniel Drake <dsd@...too.org>, Ulrich Kunitz <kune@...ne-taler.de>,
Kalle Valo <kvalo@...eaurora.org>,
"open list:TI WILINK WIRELES..." <linux-wireless@...r.kernel.org>,
netdev <netdev@...r.kernel.org>, kernel-janitors@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wireless: zd1211rw: remove redundant assignment of
pointer 'q'
On Tue, Jan 30, 2018 at 8:25 PM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Pointer q is initialized and then almost immediately afterwards being
> re-assigned the same value. Remove the second redundant assignment.
>
Don't you see strange that in the same context of the patch two users
of q are present?
How did you test this?
> Cleans up clang warning:
> drivers/net/wireless/zydas/zd1211rw/zd_mac.c:503:23: warning: Value
> stored to 'q' during its initialization is never read
> - q = &mac->ack_wait_queue;
> spin_lock_irqsave(&q->lock, flags);
>
> skb_queue_walk(q, skb) {
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists