linux-kernel - Re: [PATCH] mm: Remove PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180131130551.GS21609@dhcp22.suse.cz>
Date:   Wed, 31 Jan 2018 14:05:51 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     miles.chen@...iatek.com
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Huang Ying <ying.huang@...el.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        wsd_upstream@...iatek.com
Subject: Re: [PATCH] mm: Remove PG_highmem description

On Wed 31-01-18 17:33:32, miles.chen@...iatek.com wrote:
> From: Miles Chen <miles.chen@...iatek.com>
> 
> The commit cbe37d093707 ("[PATCH] mm: remove PG_highmem") has removed
> PG_highmem to save a page flag. So the description of PG_highmem
> is no longer needed, remove it.
> 
> Signed-off-by: Miles Chen <miles.chen@...iatek.com>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  include/linux/page-flags.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 3ec44e27aa9d..50c2b8786831 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -46,11 +46,6 @@
>   * guarantees that this bit is cleared for a page when it first is entered into
>   * the page cache.
>   *
> - * PG_highmem pages are not permanently mapped into the kernel virtual address
> - * space, they need to be kmapped separately for doing IO on the pages.  The
> - * struct page (these bits with information) are always mapped into kernel
> - * address space...
> - *
>   * PG_hwpoison indicates that a page got corrupted in hardware and contains
>   * data with incorrect ECC bits that triggered a machine check. Accessing is
>   * not safe since it may cause another machine check. Don't touch!
> -- 
> 2.12.5
> 

-- 
Michal Hocko
SUSE Labs