linux-kernel - Re: [PATCH v2] ACPI / tables: Add IORT to injectable table list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74324d8a-c144-5b21-bea1-9f2e1b891c0f@huawei.com>
Date:   Wed, 31 Jan 2018 21:32:10 +0800
From:   Hanjun Guo <guohanjun@...wei.com>
To:     "Yang, Shunyong" <shunyong.yang@...-semitech.com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>
CC:     "lenb@...nel.org" <lenb@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Zheng, Joey" <yu.zheng@...-semitech.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "Jiang, Yutang2" <yutang2.jiang@...-semitech.com>
Subject: Re: [PATCH v2] ACPI / tables: Add IORT to injectable table list

Hi Shunyong,

On 2018/1/30 9:44, Yang, Shunyong wrote:
> Hi, Rafael
> 
> Could you please help to review this patch? This is a small change to
> add ACPI_SIG_IORT to table_sigs[]. 
> Loading IORT table from initrd is very useful to debug SMMU node/device
> probe, MSI allocation, stream id translation and verifying IORT table
> from firmware. So, I add this.

It's true, mappings in IORT will be easy getting wrong, so it would be
good to test it without updating the firmware.

But I think you'd better to add your comment about why you need
IORT in the commit message in your patch, that will be useful
to convince Rafael to take your patch.

Thanks
Hanjun