linux-kernel - Re: [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180131224235.GC7637@saruman>
Date:   Wed, 31 Jan 2018 22:42:36 +0000
From:   James Hogan <jhogan@...nel.org>
To:     Corentin Labbe <clabbe.montjoie@...il.com>
Cc:     ralf@...ux-mips.org, linux-kernel@...r.kernel.org,
        linux-mips@...ux-mips.org
Subject: Re: [PATCH] MIPS: fix typo BIG_ENDIAN to CPU_BIG_ENDIAN

On Wed, Jan 17, 2018 at 07:55:27PM +0000, James Hogan wrote:
> On Wed, Jan 17, 2018 at 07:56:38PM +0100, Corentin Labbe wrote:
> > MIPS_GENERIC select some options with condition on BIG_ENDIAN which do
> > not exists.
> > Replace BIG_ENDIAN by CPU_BIG_ENDIAN which is the correct kconfig name.
> > Note that BMIP_GENERIC do the same which confirm that this patch is
> > needed.
> > 
> > Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> 
> Good spot:
> Reviewed-by: James Hogan <jhogan@...nel.org>
> 
> Probably worthy of a backport too:
> Cc: <stable@...r.kernel.org> # 4.9+

For the record, this needs the patch "usb: Move USB_UHCI_BIG_ENDIAN_*
out of USB_SUPPORT" [1] to avoid Kconfig warnings.

Thanks
James

[1] https://patchwork.linux-mips.org/patch/18559/

> 
> Cheers
> James
> 
> > ---
> >  arch/mips/Kconfig | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 13c6e5cb6055..504e78ff0b00 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -119,12 +119,12 @@ config MIPS_GENERIC
> >  	select SYS_SUPPORTS_MULTITHREADING
> >  	select SYS_SUPPORTS_RELOCATABLE
> >  	select SYS_SUPPORTS_SMARTMIPS
> > -	select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> > -	select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> > -	select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> > -	select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> > -	select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> > -	select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> > +	select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> > +	select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> > +	select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> > +	select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> > +	select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> > +	select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> >  	select USE_OF
> >  	help
> >  	  Select this to build a kernel which aims to support multiple boards,
> > -- 
> > 2.13.6
> > 
> > 



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)