linux-kernel - Re: [PATCH] Staging: fwserial: remove unnecessary parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180201082325.bb7hfaoqxuavee6o@mwanda>
Date:   Thu, 1 Feb 2018 11:23:26 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Quytelda Kahja <quytelda@...alin.org>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: fwserial: remove unnecessary parenthesis

On Wed, Jan 31, 2018 at 09:39:51PM -0800, Quytelda Kahja wrote:
> Removed parenthesis causing a coding style warning.
> 
> Signed-off-by: Quytelda Kahja <quytelda@...alin.org>
> ---
>  drivers/staging/fwserial/dma_fifo.c | 2 +-
>  drivers/staging/fwserial/fwserial.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fwserial/dma_fifo.c b/drivers/staging/fwserial/dma_fifo.c
> index 8b23a553fd4a..ead71f93f3c9 100644
> --- a/drivers/staging/fwserial/dma_fifo.c
> +++ b/drivers/staging/fwserial/dma_fifo.c
> @@ -259,7 +259,7 @@ int dma_fifo_out_complete(struct dma_fifo *fifo, struct dma_pending *complete)
>  	if (list_empty(&fifo->pending) && fifo->open == 0)
>  		return -EINVAL;
>  
> -	if (FAIL(fifo, list_empty(&fifo->pending) != (fifo->open == 0),
> +	if (FAIL(fifo, list_empty(&fifo->pending) != fifo->open == 0,

No no no...  You've changed what the code does here...  I'm so surprised
the compiler doesn't complain.

regards,
dan carpenter