linux-kernel - Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Feb 2018 09:05:55 +0000
From:   Daniel Baluta <daniel.baluta@....com>
To:     "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        Fabio Estevam <fabio.estevam@....com>
CC:     dl-linux-imx <linux-imx@....com>,
        Cosmin Samoila <cosmin.samoila@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "wakasugi.jb@...asahi-kasei.co.jp" <wakasugi.jb@...asahi-kasei.co.jp>,
        "mihai.serban@...il.com" <mihai.serban@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "S.j. Wang" <shengjiu.wang@....com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "mihai.serban@....com" <mihai.serban@....com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

Hi Fabio, Andy,

Thanks a lot for your comments. I will address them and send v2.

Few comments inline.

On Mi, 2018-01-31 at 18:12 +0200, Andy Shevchenko wrote:
> On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta <daniel.baluta@....com> wrote:
> > 
> > AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC
> > for digital audio systems.
> > 
> > Signed-off-by: Junichi Wakasugi <wakasugi.jb@...asahi-kasei.co.jp>
> > Signed-off-by: Mihai Serban <mihai.serban@....com>
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> > Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> 4 authors of the code?!

The code has a very long history. I will add under each SoB the specific
contribution.

Mihai got the code from Junichi and reworked it for 4.9. Then Shengjiu and
me added various features and cleanups.

According to DCO [1] all SoB are valid and required.


> > +MODULE_AUTHOR("Junichi Wakasugi <wakasugi.jb@...asahi-kasei.co.jp>");
> > +MODULE_AUTHOR("Mihai Serban <mihai.serban@....com>");
> 4 SoBs, 2 Authors. Please, fix accordingly.

Here I would prefer to list Junichi and Mihai because they were the main contributors.
Any other suggestion?

thanks,
Daniel.

[1] [1] https://developercertificate.org/