linux-kernel - Re: [PATCH] dm raid: don't use 'const' in function return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVPrdNESrqoXEwrbwqJ-OBQOGkMDWm_sSzaH2e7c884ow@mail.gmail.com>
Date:   Thu, 1 Feb 2018 10:24:22 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Mike Snitzer <snitzer@...hat.com>,
        Alasdair Kergon <agk@...hat.com>, dm-devel@...hat.com,
        Shaohua Li <shli@...nel.org>,
        Heinz Mauelshagen <heinzm@...hat.com>,
        linux-raid@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dm raid: don't use 'const' in function return

On Thu, Jun 16, 2016 at 11:03 AM, Arnd Bergmann <arnd@...db.de> wrote:
> A newly introduced function has 'const int' as the return type,
> but as "make W=1" reports, that has no meaning:
>
> drivers/md/dm-raid.c:510:18: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
>
> This changes the return type to plain 'int'.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 33e53f06850f ("dm raid: introduce extended superblock and new raid types to support takeover/reshaping")

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

The same issue has been reintroduced.
So please reapply commit 68c1c4d5eafc65dd ("dm raid: don't use 'const' in
function return") with

Fixes: 552aa679f2657431 ("dm raid: use rs_is_raid*()")

> index 96bcff7a0b94..55d25ac87bda 100644
> --- a/drivers/md/dm-raid.c
> +++ b/drivers/md/dm-raid.c
> @@ -507,7 +507,7 @@ static const char *raid10_md_layout_to_format(int layout)
>  }
>
>  /* Return md raid10 algorithm for @name */
> -static const int raid10_name_to_format(const char *name)
> +static int raid10_name_to_format(const char *name)
>  {
>         if (!strcasecmp(name, "near"))
>                 return ALGORITHM_RAID10_NEAR;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds