linux-kernel - Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180201122230.GC690@gmail.com>
Date:   Thu, 1 Feb 2018 13:22:30 +0100
From:   Marcus Folkesson <marcus.folkesson@...il.com>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform

On Thu, Feb 01, 2018 at 11:08:46AM +0800, Baolin Wang wrote:
> On 31 January 2018 at 22:23, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> > On Wed, Jan 31, 2018 at 4:01 AM, Baolin Wang <baolin.wang@...aro.org> wrote:
> >> On 31 January 2018 at 00:48, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> >>> On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang <baolin.wang@...aro.org> wrote:
> >>>> The Spreadtrum SC9860 platform GPIO controller contains 16 groups and
> >>>> each group contains 16 GPIOs. Each GPIO can set input/output and has
> >>>> the interrupt capability.
> >>>
> >>>> +config GPIO_SPRD
> >>>
> >>>> +       bool "Spreadtrum GPIO support"
> >>>
> >>> Either you have to put tristate here, or remove all redundant
> >>> module_*() and MODULE_*() macros.
> >>
> >> I will remove module_*() and MODULE_*() macros in next version. Thanks
> >> for your comments.
> >
> > In that case you need to explain why driver can't be module. (And
> > don't forget to replace module.h with init.h).
> 
> After more investigation, I found most GPIO dependencies can be
> deferred to probe. So I will change the GPIO driver to module level
> and change bool to tristate in next version.

Then you could replace

+static int __init sprd_gpio_init(void)
+{
+       return platform_driver_register(&sprd_gpio_driver);
+}
+subsys_initcall(sprd_gpio_init);
+
+static void __exit sprd_gpio_exit(void)
+{
+       platform_driver_unregister(&sprd_gpio_driver);
+}
+module_exit(sprd_gpio_exit);

with

module_platform_driver(sprd_gpio_driver);

> 
> -- 
> Baolin.wang
> Best Regards


Best regards
Marcus Folkesson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)