linux-kernel - Re: [alsa-devel] [PATCH 1/1] ASoC: stm32: add of dependency for stm32 drivers

Open Source and information security mailing list archives

Message-ID: <3bd3ba89-5c69-4485-c913-ff1c1ad67190@st.com>
Date:   Thu, 1 Feb 2018 13:19:28 +0000
From:   Olivier MOYSAN <olivier.moysan@...com>
To:     Ladislav Michl <ladis@...ux-mips.org>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kernel@...inux.com" <kernel@...inux.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnaud POULIQUEN <arnaud.pouliquen@...com>,
        Benjamin GAIGNARD <benjamin.gaignard@...com>
Subject: Re: [alsa-devel] [PATCH 1/1] ASoC: stm32: add of dependency for stm32
 drivers

hello,

On 02/01/2018 10:10 AM, Ladislav Michl wrote:
> On Thu, Feb 01, 2018 at 09:54:41AM +0100, Olivier Moysan wrote:
>> Add of dependency for STM32 ASoC drivers.
>> DFSDM of dependency is already inherited
>> from STM32_DFSDM_ADC dependency.
>>
>> Signed-off-by: olivier moysan <olivier.moysan@...com>
>> ---
>>   sound/soc/stm/Kconfig | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig
>> index 3ad881f..b5375f9 100644
>> --- a/sound/soc/stm/Kconfig
>> +++ b/sound/soc/stm/Kconfig
>> @@ -3,6 +3,7 @@ menu "STMicroelectronics STM32 SOC audio support"
>>   config SND_SOC_STM32_SAI
>>   	tristate "STM32 SAI interface (Serial Audio Interface) support"
>>   	depends on ARCH_STM32 || COMPILE_TEST
>> +	depends on OF
> 
> depends on (ARCH_STM32 && OF) || COMPILE_TEST ?
> 

I can find in many configs "depends on OF && (ARCH_X || COMPILE_TEST)"
This seems reasonable to me, as the driver always requires OF 
dependency, regardless the compilation context.
In fact, I cannot see why OF would not have to be selected
for COMPILE_TEST.

BRs

>>   	depends on SND_SOC
>>   	select SND_SOC_GENERIC_DMAENGINE_PCM
>>   	select REGMAP_MMIO
>> @@ -12,6 +13,7 @@ config SND_SOC_STM32_SAI
>>   config SND_SOC_STM32_I2S
>>   	tristate "STM32 I2S interface (SPI/I2S block) support"
>>   	depends on ARCH_STM32 || COMPILE_TEST
>> +	depends on OF
>>   	depends on SND_SOC
>>   	select SND_SOC_GENERIC_DMAENGINE_PCM
>>   	select REGMAP_MMIO
>> @@ -21,6 +23,7 @@ config SND_SOC_STM32_I2S
>>   config SND_SOC_STM32_SPDIFRX
>>   	tristate "STM32 S/PDIF receiver (SPDIFRX) support"
>>   	depends on ARCH_STM32 || COMPILE_TEST
>> +	depends on OF
>>   	depends on SND_SOC
>>   	select SND_SOC_GENERIC_DMAENGINE_PCM
>>   	select REGMAP_MMIO
>> -- 
>> 1.9.1
>>
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@...a-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives