linux-kernel - Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180201134840.GA10785@sirena.org.uk>
Date:   Thu, 1 Feb 2018 13:48:40 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Daniel Baluta <daniel.baluta@....com>,
        Fabio Estevam <fabio.estevam@....com>,
        dl-linux-imx <linux-imx@....com>,
        Cosmin Samoila <cosmin.samoila@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "wakasugi.jb@...asahi-kasei.co.jp" <wakasugi.jb@...asahi-kasei.co.jp>,
        "mihai.serban@...il.com" <mihai.serban@...il.com>,
        "S.j. Wang" <shengjiu.wang@....com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "mihai.serban@....com" <mihai.serban@....com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

On Thu, Feb 01, 2018 at 03:20:38PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 1, 2018 at 11:05 AM, Daniel Baluta <daniel.baluta@....com> wrote:

> >> > Signed-off-by: Junichi Wakasugi <wakasugi.jb@...asahi-kasei.co.jp>
> >> > Signed-off-by: Mihai Serban <mihai.serban@....com>
> >> > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> >> > Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> >> 4 authors of the code?!

> > The code has a very long history. I will add under each SoB the specific
> > contribution.

> > Mihai got the code from Junichi and reworked it for 4.9. Then Shengjiu and
> > me added various features and cleanups.

> > Any other suggestion?

> Yes, please, put detailed credits in commit message to not shock
> people with so many SoB w/o explanation why.

Honestly the signoffs above are nothing unusual for a driver contributed
by a vendor - things are often bouncing around internally for ages and
it's good to keep credits for people.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)