linux-kernel - Re: [PATCH] net: bridge: Fix uninitialized error in br_fdb_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180201.094805.1174548294600347835.davem@davemloft.net>
Date:   Thu, 01 Feb 2018 09:48:05 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     geert@...ux-m68k.org
Cc:     nikolay@...ulusnetworks.com, stephen@...workplumber.org,
        arnd@...db.de, bridge@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bridge: Fix uninitialized error in
 br_fdb_sync_static()

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Thu,  1 Feb 2018 11:25:27 +0100

> With gcc-4.1.2.:
> 
>     net/bridge/br_fdb.c: In function ‘br_fdb_sync_static’:
>     net/bridge/br_fdb.c:996: warning: ‘err’ may be used uninitialized in this function
> 
> Indeed, if the list is empty, err will be uninitialized, and will be
> propagated up as the function return value.
> 
> Fix this by preinitializing err to zero.
> 
> Fixes: eb7935830d00b9e0 ("net: bridge: use rhashtable for fdbs")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied, thanks Geert.