linux-kernel - Re: [PATCH v3 12/21] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180201151157.44vecqprje6dqzjl@insfl13.etec.uni-karlsruhe.de>
Date:   Thu, 1 Feb 2018 16:11:57 +0100
From:   Moritz Fischer <mdf@...nel.org>
To:     Wu Hao <hao.wu@...el.com>
Cc:     Alan Tull <atull@...nel.org>, Moritz Fischer <mdf@...nel.org>,
        linux-fpga@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-api@...r.kernel.org, "Kang, Luwei" <luwei.kang@...el.com>,
        "Zhang, Yi Z" <yi.z.zhang@...el.com>,
        Tim Whisonant <tim.whisonant@...el.com>,
        Enno Luebbers <enno.luebbers@...el.com>,
        Shiva Rao <shiva.rao@...el.com>,
        Christopher Rauer <christopher.rauer@...el.com>,
        Xiao Guangrong <guangrong.xiao@...ux.intel.com>
Subject: Re: [PATCH v3 12/21] fpga: dfl: fme: add
 FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

On Thu, Feb 01, 2018 at 01:11:07PM +0800, Wu Hao wrote:
> On Wed, Jan 31, 2018 at 09:31:59AM -0600, Alan Tull wrote:
> > On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao <hao.wu@...el.com> wrote:
> > 
> > Hi Hao,
> > 
> > One fix again, otherwise please add my ack to subsequent versions.
> 
> Sure. Thanks for the review.
> 
> > 
> > > FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which
> > > need to be supported by all feature devices drivers including FME and AFU.
> > > Userspace application can use these ioctl interfaces to get the API info
> > > and check if specific extension is supported or not in current driver.
> > >
> > > This patch implements above 2 ioctls in FPGA Management Engine (FME)
> > > driver.
> > >
> > > Signed-off-by: Tim Whisonant <tim.whisonant@...el.com>
> > > Signed-off-by: Enno Luebbers <enno.luebbers@...el.com>
> > > Signed-off-by: Shiva Rao <shiva.rao@...el.com>
> > > Signed-off-by: Christopher Rauer <christopher.rauer@...el.com>
> > > Signed-off-by: Xiao Guangrong <guangrong.xiao@...ux.intel.com>
> > > Signed-off-by: Wu Hao <hao.wu@...el.com>
> > 
> > Acked-by: Alan Tull <atull@...nel.org>
Acked-by: Moritz Fischer <mdf@...nel.org>
> > 
> > > diff --git a/include/uapi/linux/fpga-dfl.h b/include/uapi/linux/fpga-dfl.h
> > > new file mode 100644
> > > index 0000000..b46d124
> > > --- /dev/null
> > > +++ b/include/uapi/linux/fpga-dfl.h
> > > @@ -0,0 +1,50 @@
> > > +/*
> > > + * Header File for FPGA DFL User API
> > > + *
> > > + * Copyright (C) 2017 Intel Corporation, Inc.
> > > + *
> > > + * Authors:
> > > + *   Kang Luwei <luwei.kang@...el.com>
> > > + *   Zhang Yi <yi.z.zhang@...el.com>
> > > + *   Wu Hao <hao.wu@...el.com>
> > > + *   Xiao Guangrong <guangrong.xiao@...ux.intel.com>
> > > + *
> > > + * This work is licensed under the terms of the GNU GPL version 2.
> > 
> > Please remove above line.  My understanding is that we are supposed to
> > not combine SPDX with other license statements.
> > 
> > > + * SPDX-License-Identifier: GPL-2.0
> > > + */
> > 
> > // SPDX-License-Identifier: GPL-2.0
> > 
> > As first line of file.
> 
> Sure, I will fix this in the next version.
> 
> Thanks
> Hao
> 
> > 
> > Thanks,
> > Alan

Thanks,

Moritz

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)