linux-kernel - Re: [PATCH] MIPS: Fix trailing semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Feb 2018 16:08:01 +0000
From:   James Hogan <jhogan@...nel.org>
To:     Luis de Bethencourt <luisbg@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Al Viro <viro@...iv.linux.org.uk>, linux-mips@...ux-mips.org
Subject: Re: [PATCH] MIPS: Fix trailing semicolon

On Tue, Jan 23, 2018 at 01:38:03PM +0000, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@...nel.org>

Applied to my 4.16 branch,

Thanks
James

> ---
> 
> Hi,
> 
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
> 
> Best regards 
> Luis
> 
> 
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> 
>  arch/mips/include/asm/checksum.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/checksum.h b/arch/mips/include/asm/checksum.h
> index 77cad232a1c6..e8161e4dfde7 100644
> --- a/arch/mips/include/asm/checksum.h
> +++ b/arch/mips/include/asm/checksum.h
> @@ -110,7 +110,7 @@ __wsum csum_partial_copy_nocheck(const void *src, void *dst,
>   */
>  static inline __sum16 csum_fold(__wsum csum)
>  {
> -	u32 sum = (__force u32)csum;;
> +	u32 sum = (__force u32)csum;
>  
>  	sum += (sum << 16);
>  	csum = (sum < csum);
> -- 
> 2.15.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)