linux-kernel - Re: [PATCH] Input: adp5520-keys: Delete an error message for a failed memory allocation in adp5520_keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Feb 2018 17:27:25 +0100
From:   Michael Hennerich <michael.hennerich@...log.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        <linux-input@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] Input: adp5520-keys: Delete an error message for a failed
 memory allocation in adp5520_keys_probe()

On 27.01.2018 15:20, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 27 Jan 2018 15:15:52 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Michael Hennerich <michael.hennerich@...log.com>

> ---
>   drivers/input/keyboard/adp5520-keys.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/input/keyboard/adp5520-keys.c b/drivers/input/keyboard/adp5520-keys.c
> index f0b9b37bde58..72e01cb77881 100644
> --- a/drivers/input/keyboard/adp5520-keys.c
> +++ b/drivers/input/keyboard/adp5520-keys.c
> @@ -91,10 +91,8 @@ static int adp5520_keys_probe(struct platform_device *pdev)
>   		return -EINVAL;
>   
>   	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
> -	if (!dev) {
> -		dev_err(&pdev->dev, "failed to alloc memory\n");
> +	if (!dev)
>   		return -ENOMEM;
> -	}
>   
>   	input = devm_input_allocate_device(&pdev->dev);
>   	if (!input)
>