linux-kernel - Re: [PATCH] irqchip/gic-v3: Ignore disabled ITS nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180201164029.GA23162@codeaurora.org>
Date:   Thu, 1 Feb 2018 08:40:29 -0800
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Marc Zyngier <marc.zyngier@....com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Rajendra Nayak <rnayak@...eaurora.org>
Subject: Re: [PATCH] irqchip/gic-v3: Ignore disabled ITS nodes

On 02/01, Marc Zyngier wrote:
> On 29/01/18 16:49, Stephen Boyd wrote:
> > @@ -1815,6 +1815,8 @@ static int __init its_of_probe(struct device_node *node)
> >  
> >  	for (np = of_find_matching_node(node, its_device_id); np;
> >  	     np = of_find_matching_node(np, its_device_id)) {
> > +		if (!of_device_is_available(np))
> > +			continue;
> >  		if (!of_property_read_bool(np, "msi-controller")) {
> >  			pr_warn("%s: no msi-controller property, ITS ignored\n",
> >  				np->full_name);
> > 
> 
> Can you also address the same thing in
> drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c?

Sure.

> 
> Do we need a cc to stable for this?
> 

We don't have any dts files with the disabled node in mainline,
so no?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project