linux-kernel - Re: [PATCH] KVM: x86: fix backward migration with async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c820ef8e-b352-ef28-4756-d6949f718ec0@redhat.com>
Date:   Thu, 1 Feb 2018 14:33:10 -0500
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Radim Krčmář <rkrcmar@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Wanpeng Li <wanpeng.li@...mail.com>, stable@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: fix backward migration with async_PF

On 01/02/2018 14:10, Radim Krčmář wrote:
>>>
>> This check will break migration if the source guest and host both have
>> the recent kernels which support KVM_ASYNC_PF_DELIVERY_AS_PF_VMEXIT, so
>> I am not sure about it.  Otherwise, the patch is okay!
> Good point, breaking forward migration is worse than doing nothing.
> 
> A compromise solution would be to drop the feature check from the
> hypervisor.  Newer guests would work everywhere and there would be no
> change to old systems, so v4.13-v4.15 guests could at least upgrade.
> 
> Slightly better than doing nothing, IMO,

Yes, I agree.  Just removing the guest_kvm_cpuid_has should be fine.

Paolo