[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 3 Feb 2018 00:06:26 +0100
From: "Jan H. Schönherr" <jschoenh@...zon.de>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Ingo Molnar <mingo@...hat.com>,
Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
"H. Peter Anvin" <hpa@...or.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: e820: Implement a range manipulation operator
On 02/02/2018 09:50 PM, Andy Shevchenko wrote:
> On Fri, Feb 2, 2018 at 1:13 AM, Jan H. Schönherr <jschoenh@...zon.de> wrote:
>
>> + [KNL,ACPI] Convert memory within the specified region
>> + from <oldtype> to <newtype>. If "-<oldtype>" is left
>> + out, the whole region will be marked as <newtype>,
>> + even if previously unavailable. If "+<newtype>" is left
>> + out, matching memory will be removed. Types are
>> + specified as e820 types, eg, 1==RAM, 2==reserved,
>> + 3==ACPI, 12==PRAM.
>
> s/==/ = /g
Sure. I've also properly abbreviated that "e.g.".
>> + } else if (*p == '%') {
>> + enum e820_type from = 0, to = 0;
>> +
>> + start_at = memparse(p + 1, &p);
>> + if (*p == '-')
>> + from = simple_strtoull(p + 1, &p, 0);
>> + if (*p == '+')
>> + to = simple_strtoull(p + 1, &p, 0);
>> + if (*p != 0)
>
> if (*p)
>
> or
>
> if (*p != '\0')
>
> ?
Something similar to the latter is used in the function already. The latter it is.
Regards
Jan
Powered by blists - more mailing lists