[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 01 Feb 2018 20:38:51 -0600
From: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To: David Miller <davem@...emloft.net>
Cc: gustavo@...eddedor.com, hswong3i@...il.com, hlhung3i@...il.com,
kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit
Hi David,
Quoting David Miller <davem@...emloft.net>:
> From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
> Date: Wed, 31 Jan 2018 18:24:07 -0600
>
>> Cast to s64 some variables and a macro in order to give the
>> compiler complete information about the proper arithmetic to
>> use. Notice that these elements are used in contexts that
>> expect expressions of type s64 (64 bits, signed).
>>
>> Currently such expression are being evaluated using 32-bit
>> arithmetic.
>>
>> Addresses-Coverity-ID: 200687
>> Addresses-Coverity-ID: 200688
>> Addresses-Coverity-ID: 200689
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>
> Sorry, I'm not applying this, the domain of the input values
> means that the calculation cannot overflow.
Yep, that's fine.
Thanks for the feedback.
--
Gustavo
Powered by blists - more mailing lists