linux-kernel - Re: [PATCH] remove raw pointer from printk message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180203094948.k5se54bdjudg6iei@pd.tnic>
Date:   Sat, 3 Feb 2018 10:49:48 +0100
From:   Borislav Petkov <bp@...e.de>
To:     540263207@...com
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Tom Lendacky <thomas.lendacky@....com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Laura Abbott <labbott@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>
Subject: Re: [PATCH] remove raw pointer from printk message

On Sat, Feb 03, 2018 at 01:48:19PM +0800, 540263207@...com wrote:
> From: qize wang <540263207@...com>
> 
> The set_real_mode_mem function always print a raw kernel pointer to the kernel log
> at every boot. So just remove raw pointer from printk message.
> 
> Reported-by: qize wang <wang_qize@...ustech.com.cn>
> Cc: stable <stable@...r.kernel.org>
> Signed-off-by: qize wang <540263207@...com>
> ---
>  arch/x86/realmode/init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c
> index d101058..d76a138 100644
> --- a/arch/x86/realmode/init.c
> +++ b/arch/x86/realmode/init.c
> @@ -20,8 +20,8 @@ void __init set_real_mode_mem(phys_addr_t mem, size_t size)
>  	void *base = __va(mem);
>  
>  	real_mode_header = (struct real_mode_header *) base;
> -	printk(KERN_DEBUG "Base memory trampoline at [%p] %llx size %zu\n",
> -	       base, (unsigned long long)mem, size);
> +	printk(KERN_DEBUG "Base memory trampoline at %llx size %zu\n",
> +	       (unsigned long long)mem, size);
>  }
>  
>  void __init reserve_real_mode(void)
> -- 

No need, it gets hashed already:

[    0.000000] Base memory trampoline at [        (ptrval)] 99000 size 24576

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--