linux-kernel - linux-next: build failure in Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180205092818.5ba62766@canb.auug.org.au>
Date:   Mon, 5 Feb 2018 09:28:18 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: linux-next: build failure in Linus' tree

Hi Linus,

Just building you tree, today's linux-next build (arm multi_v7_defconfig)
failed like this:

drivers/usb/host/ehci-st.c: In function 'st_ehci_suspend':
drivers/usb/host/ehci-st.c:300:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_sleep_state(dev);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/ehci-st.c: In function 'st_ehci_resume':
drivers/usb/host/ehci-st.c:312:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_default_state(dev);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  23c35f48f5fb ("pinctrl: remove include file from <linux/device.h>")

I have added teh following fix patch for today:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Mon, 5 Feb 2018 09:24:30 +1100
Subject: [PATCH] pinctrl: files should directly include apis they use

Fixes: 23c35f48f5fb ("pinctrl: remove include file from <linux/device.h>")
Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/usb/host/ehci-st.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c
index 3c1362ab70be..dc42981047c9 100644
--- a/drivers/usb/host/ehci-st.c
+++ b/drivers/usb/host/ehci-st.c
@@ -23,6 +23,7 @@
 #include <linux/usb.h>
 #include <linux/usb/hcd.h>
 #include <linux/usb/ehci_pdriver.h>
+#include <linux/pinctrl/consumer.h>
 
 #include "ehci.h"
 
-- 
2.15.1

-- 
Cheers,
Stephen Rothwell