linux-kernel - Re: [PATCH] extcon: int3496: process id-pin first so that we start with the right status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <5A779715.7000709@samsung.com>
Date:   Mon, 05 Feb 2018 08:28:21 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: int3496: process id-pin first so that we start
 with the right status

On 2018년 02월 02일 17:10, Hans de Goede wrote:
> Hi,
> 
> On 02-02-18 01:32, Chanwoo Choi wrote:
>> On 2018년 01월 26일 04:39, Hans de Goede wrote:
>>> Some other drivers may be waiting for our extcon to show-up (exiting their
>>> probe methods with -EPROBE_DEFER until we show up).
>>>
>>> These drivers will typically get the cable state directly after getting
>>> the extcon, this commit changes the int3496 code to process the id-pin
>>> before registering the extcon, so that other drivers see the correct state
>>> right away.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
>>> ---
>>>   drivers/extcon/extcon-intel-int3496.c | 7 ++++---
>>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
>>> index c8691b5a9cb0..b23ee9d993a3 100644
>>> --- a/drivers/extcon/extcon-intel-int3496.c
>>> +++ b/drivers/extcon/extcon-intel-int3496.c
>>> @@ -131,6 +131,10 @@ static int int3496_probe(struct platform_device *pdev)
>>>       if (IS_ERR(data->gpio_usb_mux))
>>>           dev_info(dev, "can't request USB MUX GPIO\n");
>>>   +    /* process id-pin first so that we start with the right status */
>>> +    queue_delayed_work(system_wq, &data->work, 0);
>>> +    flush_delayed_work(&data->work);
>>> +
>>>       /* register extcon device */
>>>       data->edev = devm_extcon_dev_allocate(dev, int3496_cable);
>>>       if (IS_ERR(data->edev))
>>> @@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev)
>>>           return ret;
>>>       }
>>>   -    /* queue initial processing of id-pin */
>>> -    queue_delayed_work(system_wq, &data->work, 0);
>>> -
>>>       platform_set_drvdata(pdev, data);
>>>         return 0;
>>>
>>
>> Looks good to me.
>> How about adding the 'Fixes' commit id on patch description?
> 
> Right, this could use a:
> 
> Fixes: 2f556bdb9f2e ("extcon: int3496: Add Intel INT3496 ACPI device extcon driver")
>

Please resend this patch Because you need to send the Linux stable mailing list.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics