linux-kernel - Re: [PATCH] iio: srf08: fix link error "devm_iio_triggered_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180204112136.6c9ad790@archlinux>
Date:   Sun, 4 Feb 2018 11:21:36 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andreas Klinger <ak@...klinger.de>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: srf08: fix link error
 "devm_iio_triggered_buffer_setup" undefined

On Thu, 1 Feb 2018 21:49:24 +0100
Andreas Klinger <ak@...klinger.de> wrote:

> Functions for triggered buffer support are needed by this module.
> If they are not defined accidentally by another driver, there's an error
> thrown out while linking.
> 
> Add a select of IIO_BUFFER and IIO_TRIGGERED_BUFFER in the Kconfig file.
> 
> Signed-off-by: Andreas Klinger <ak@...klinger.de>

Applied to the fixes-togreg-post-rc1 branch of iio.git with a fixes
tag added.  Please always track down the patch that introduced the
problem and add a fixes tag.  It makes it much easier for the stable
trees to know when to apply the patch or not.

I put the patch that introduced the triggered support in the first
place as that seemed likely to be the place that the issue was
introduced.

Thanks,

Jonathan
> ---
>  drivers/iio/proximity/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/proximity/Kconfig b/drivers/iio/proximity/Kconfig
> index fcb1c4ba5e41..f726f9427602 100644
> --- a/drivers/iio/proximity/Kconfig
> +++ b/drivers/iio/proximity/Kconfig
> @@ -68,6 +68,8 @@ config SX9500
>  
>  config SRF08
>  	tristate "Devantech SRF02/SRF08/SRF10 ultrasonic ranger sensor"
> +	select IIO_BUFFER
> +	select IIO_TRIGGERED_BUFFER
>  	depends on I2C
>  	help
>  	  Say Y here to build a driver for Devantech SRF02/SRF08/SRF10