linux-kernel - Re: [PATCH v3] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <334D3FD8-FF56-410C-8B33-B973EDFDD7D7@canonical.com>
Date:   Mon, 5 Feb 2018 13:06:37 +0800
From:   Kai Heng Feng <kai.heng.feng@...onical.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        "Schmauss, Erik" <erik.schmauss@...el.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mario Limonciello <mario.limonciello@...l.com>
Subject: Re: [PATCH v3] ACPI: Parse entire table as a term_list for Dell XPS
 9570 and Precision M5530



> On Feb 4, 2018, at 4:26 PM, Rafael J. Wysocki <rafael@...nel.org> wrote:
> 
> On Wed, Jan 31, 2018 at 5:56 AM, Kai-Heng Feng
> <kai.heng.feng@...onical.com> wrote:
>> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out
>> of box.
>> 
>> The touchpad relies on its _INI method to update its _HID value from
>> XXXX0000 to SYNA2393.
>> Also, the _STA relies on value of I2CN to report correct status.
>> 
>> Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be
>> correctly set up, and _INI can get run. The ACPI table in this machine
>> is designed to get parsed this way.
>> 
>> Also, change the quirk table to a more generic name.
>> 
>> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198515
>> Cc: Mario Limonciello <mario.limonciello@...l.com>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
>> ---
>> v3: Put the function under right #ifdef, comment adjustment
>> 
>> v2: Andy's suggestion, merge to a single quirk table.
>> 
>> drivers/acpi/bus.c | 40 +++++++++++++++++++++++++++++++++-------
>> 1 file changed, 33 insertions(+), 7 deletions(-)
>> 
>> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
>> index 4d0979e02a28..7cb18bc2b59a 100644
>> --- a/drivers/acpi/bus.c
>> +++ b/drivers/acpi/bus.c
>> @@ -66,10 +66,39 @@ static int set_copy_dsdt(const struct dmi_system_id *id)
>>        return 0;
>> }
>> #endif
>> +static int set_gbl_term_list(const struct dmi_system_id *id)
>> +{
>> +       pr_notice("%s detected - parse the entire table as a term_list\n",
>> +                 id->ident);
> 
> This is not a useful message for a user (who may not know what
> trem_list is).  Care to change it to something more useful, or even
> drop it?

Yes, I think it should be dropped. The information is already in the
commit log and comment section, if the user really wants to know
more.

Kai-Heng