linux-kernel - Re: [PATCH 1/2] dt-bindings: fsi: Add optional property no-scan-on-init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Feb 2018 00:07:35 -0600
From:   Rob Herring <robh@...nel.org>
To:     Joel Stanley <joel@....id.au>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        Christopher Bostic <cbostic@...ux.vnet.ibm.com>,
        Jeremy Kerr <jk@...abs.org>,
        Eddie James <eajames@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: fsi: Add optional property
 no-scan-on-init

On Tue, Jan 30, 2018 at 04:21:15PM +1030, Joel Stanley wrote:
> From: Christopher Bostic <cbostic@...ux.vnet.ibm.com>
> 
> Add an optional FSI master property 'no-scan-on-init.  This
> can be specified to indicate that a master should not be
> automatically scanned at init time.  This is required in cases
> where a scan could interfere with another FSI master on the same
> bus.
> 
> Signed-off-by: Christopher Bostic <cbostic@...ux.vnet.ibm.com>
> Acked-by: Jeremy Kerr <jk@...abs.org>
> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>  Documentation/devicetree/bindings/fsi/fsi.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/fsi/fsi.txt b/Documentation/devicetree/bindings/fsi/fsi.txt
> index 4eaf488d4015..ab516c673a4b 100644
> --- a/Documentation/devicetree/bindings/fsi/fsi.txt
> +++ b/Documentation/devicetree/bindings/fsi/fsi.txt
> @@ -56,6 +56,13 @@ addresses (link index and slave ID), and no size:
>      #address-cells = <2>;
>      #size-cells = <0>;
>  
> +An optional boolean property can be added to indicate that a particular master
> +should not scan for connected devices at initialization time.  This is
> +necessary in cases where a scan could cause arbitration issues with other
> +masters that may be present on the bus.
> +
> +    no-scan-on-init;
> +

The formatting here is a bit strange compared to most bindings, but no 
point in reformatting the document to add one property.

Reviewed-by: Rob Herring <robh@...nel.org>

Rob