linux-kernel - RE: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Feb 2018 12:57:18 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "Asutosh Das (asd)" <asutoshd@...eaurora.org>,
        "subhashj@...eaurora.org" <subhashj@...eaurora.org>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "vivek.gautam@...eaurora.org" <vivek.gautam@...eaurora.org>,
        "rnayak@...eaurora.org" <rnayak@...eaurora.org>,
        "vinholikatti@...il.com" <vinholikatti@...il.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        Venkat Gopalakrishnan <venkatg@...eaurora.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] scsi: ufs: make sure all interrupts are processed



> >>> -----Original Message-----
> >>> From: linux-scsi-owner@...r.kernel.org [mailto:linux-scsi-
> >>> owner@...r.kernel.org] On Behalf Of Asutosh Das
> >>> Sent: Tuesday, January 30, 2018 6:54 AM
> >>> To: subhashj@...eaurora.org; cang@...eaurora.org;
> >>> vivek.gautam@...eaurora.org; rnayak@...eaurora.org;
> >>> vinholikatti@...il.com; jejb@...ux.vnet.ibm.com;
> >>> martin.petersen@...cle.com
> >>> Cc: linux-scsi@...r.kernel.org; Venkat Gopalakrishnan
> >>> <venkatg@...eaurora.org>; Asutosh Das <asutoshd@...eaurora.org>;
> >>> open list <linux-kernel@...r.kernel.org>
> >>> Subject: [PATCH 1/1] scsi: ufs: make sure all interrupts are
> >>> processed
> >>>
> >>> From: Venkat Gopalakrishnan <venkatg@...eaurora.org>
> >>>
> >>> As multiple requests are submitted to the ufs host controller in
> >>> parallel there could be instances where the command completion
> >>> interrupt arrives later for a request that is already processed
> >>> earlier as the corresponding doorbell was cleared when handling the
> >>> previous interrupt. Read the interrupt status in a loop after
> >>> processing the received interrupt to catch such interrupts and
> >>> handle it.
> >>>
> >>> Signed-off-by: Venkat Gopalakrishnan <venkatg@...eaurora.org>
> >>> Signed-off-by: Asutosh Das <asutoshd@...eaurora.org>
Tested-by: avri.altman@....com

Tested on kirin960 (mate9)  and msm8998 (htc11), both where interrupt aggregation is not allowed.

As a side note, I noticed that this patch is part of several patches, fixing some qcom-staff.
Maybe you want to put them all in a patchset?

Thanks,
Avri