linux-kernel - Re: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Feb 2018 02:30:57 +0100
From:   Ulf Magnusson <ulfalizer@...il.com>
To:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        tfiga@...omium.org, paul.burton@...s.com, m.szyprowski@...sung.com,
        egtvedt@...fundet.no, Linus Walleij <linus.walleij@...aro.org>,
        vgupta@...opsys.com, mgorman@...hsingularity.net, hch@....de,
        mina86@...a86.com, robh@...nel.org, sboyd@...eaurora.org,
        paulus@...abs.org, will.deacon@....com, tony@...mide.com,
        Nicholas Piggin <npiggin@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Ulf Magnusson <ulfalizer@...il.com>,
        Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <albert@...ive.com>, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select

On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson <ulfalizer@...il.com> wrote:
> The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743
> ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should
> just be selected explicitly if needed.
>
> Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV.
>
> See commit 0145071b3314 ("x86: Do away with
> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do
> away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> ---
>  arch/riscv/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index ff69c77b9e78..716e90e60e5c 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -19,7 +19,6 @@ config RISCV
>         select GENERIC_STRNLEN_USER
>         select GENERIC_SMP_IDLE_THREAD
>         select GENERIC_ATOMIC64 if !64BIT || !RISCV_ISA_A
> -       select ARCH_WANT_OPTIONAL_GPIOLIB
>         select HAVE_MEMBLOCK
>         select HAVE_MEMBLOCK_NODE_MAP
>         select HAVE_DMA_API_DEBUG
> --
> 2.14.1
>

There's also a select of a globally undefined symbol RISCV_IRQ_INTC
here. I couldn't dig up any historical or unmerged definition for it
either. Googling just gets you the select.

Cheers,
Ulf