linux-kernel - Re: [PATCH] net: phy-micrel: remove redundant initialization of pointer of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180205151122.GE11811@lunn.ch>
Date:   Mon, 5 Feb 2018 16:11:22 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Colin King <colin.king@...onical.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy-micrel: remove redundant initialization of
 pointer of_node

On Mon, Feb 05, 2018 at 12:47:59PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer of_node is initialized with a value that is never read, of_node
> is later updated with a new value instead, hence the initialization is
> redundant and can be removed.  Also remove unused pointer dev and
> remove an empty line.
> 
> Cleans up clang warnings:
> drivers/net/phy/micrel.c:393:28: warning: Value stored to 'of_node'
> during its initialization is never read
> drivers/net/phy/micrel.c:532:28: warning: Value stored to 'of_node'
> during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Hi Colin

You probably need to repost once netdev re-opens.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew