linux-kernel - Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180205155048.GA22036@codeaurora.org>
Date:   Mon, 5 Feb 2018 15:50:48 +0000
From:   Lina Iyer <ilina@...eaurora.org>
To:     tglx@...utronix.de, jason@...edaemon.net, marc.zyngier@....com
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        sboyd@...eaurora.org, rnayak@...eaurora.org,
        asathyak@...eaurora.org, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH RFC v2 3/3] drivers: irqchip: pdc: log PDC info in FTRACE

Hi Steve,

On Fri, Feb 02 2018 at 14:22 +0000, Lina Iyer wrote:
>From: Archana Sathyakumar <asathyak@...eaurora.org>
>
>Log key PDC pin configuration in FTRACE.
>
>Cc: Steven Rostedt <rostedt@...dmis.org>
>Signed-off-by: Archana Sathyakumar <asathyak@...eaurora.org>
>Signed-off-by: Lina Iyer <ilina@...eaurora.org>
>---
> drivers/irqchip/qcom-pdc.c |  7 ++++++
> include/trace/events/pdc.h | 55 ++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 62 insertions(+)
> create mode 100644 include/trace/events/pdc.h
>
>diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
>index a392380eada6..7f177ad88713 100644
>--- a/drivers/irqchip/qcom-pdc.c
>+++ b/drivers/irqchip/qcom-pdc.c
>@@ -26,6 +26,8 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/types.h>
>+#define CREATE_TRACE_POINTS
>+#include "trace/events/pdc.h"
>
In addition to this PDC patch, there are a few drivers with FTRACE
support coming for up QCOM SoCs. Would it make sense to open up a new
sub-folder for SoC specific FTRACE like say,
trace/events/soc/
trace/events/soc/qcom/

What would be your recommendation?

At the very least, I am thinking of renaming this file to
trace/events/qcom-pdc.h.

Thanks,
Lina